Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learners should not hold references to widgets #9

Open
astaric opened this issue Nov 24, 2017 · 3 comments
Open

Learners should not hold references to widgets #9

astaric opened this issue Nov 24, 2017 · 3 comments

Comments

@astaric
Copy link
Member

astaric commented Nov 24, 2017

When learners are used with Tests & Score widget, they get deep_copied, which is implemented in python as pickling and unpickling. If a learner holds a reference to a widget, this currently results in a crash, as widgets cannot be pickled. But even if they could be, this would result in an unexpected behaviour where we would end up with two instances of the same widget, but only one node on a canvas.

See biolab/orange3#2793

@bernardofn
Copy link

Any idea when this will be solved?

@astaric
Copy link
Member Author

astaric commented Apr 19, 2018

Sadly, no.

This add-on has been developed as a GSoC 2016 project but has not been maintained since. If you want, you can take a look at the code base and try to submit a pull request to fix the problem.

The simplest fix would be to constructs learners in widgets without callbacks, avoiding the problem alltogether.

@bernardofn
Copy link

bernardofn commented Apr 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants