Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💅 noParameterAssign doesnt catch single parameter case without parens #5409

Open
1 task done
pbarbiero opened this issue Mar 21, 2025 · 1 comment
Open
1 task done

💅 noParameterAssign doesnt catch single parameter case without parens #5409

pbarbiero opened this issue Mar 21, 2025 · 1 comment
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@pbarbiero
Copy link

pbarbiero commented Mar 21, 2025 •
edited
Loading

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Linter:
  JavaScript enabled:           true
  Enabled rules:
  lint/correctness/noParameterAssign

Rule name

noParameterAssign

Playground link

https://biomejs.dev/playground/?arrowParentheses=as-needed&lintRules=all&code=YwBvAG4AcwB0ACAAZABvAFMAbwBtAGUAdABoAGkAbgBnACAAPQAgAHIAZQBxACAAPQA%2BACAAewAKACAAIAByAGUAcQAgAD0AIAB7AH0AOwAgAC8ALwAgAGQAbwBlAHMAbgB0ACAAZgBsAGEAZwAKAH0AOwAKAAoAYwBvAG4AcwB0ACAAZABvAFMAbwBtAGUAdABoAGkAbgBnADIAIAA9ACAAKAByAGUAcQAsACAAcgBlAHEAMgApACAAPQA%2BACAAewAKACAAIAByAGUAcQAgAD0AIAB7AH0AOwAgAC8ALwAgAGcAZQB0AHMAIABmAGwAYQBnAGcAZQBkAAoAfQA7AA%3D%3D

Expected result

Rule triggers when reassigning even to a single parameter when Arrow Parenthesis is set to "As Needed"

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@pbarbiero pbarbiero added the S-Needs triage Status: this issue needs to be triaged label Mar 21, 2025
@siketyan siketyan added good first issue Good for newcomers A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug and removed S-Needs triage Status: this issue needs to be triaged labels Mar 22, 2025
@ematipico
Copy link
Member

@pbarbiero can you update the reproduction and enable all rules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Linter Area: linter good first issue Good for newcomers L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ematipico @siketyan @pbarbiero