Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests break in other timezones #58

Open
dominicrutk opened this issue Jul 1, 2019 · 2 comments
Open

Tests break in other timezones #58

dominicrutk opened this issue Jul 1, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@dominicrutk
Copy link
Contributor

The test suites bucket.test.js and schedule.test.js fail when the system timezone isn't set to CST. The tests should be timezone agnostic.
@dominicrutk
Copy link
Contributor Author

Also, we could consider adding a timezone to the system config file that defaults to GMT. This would make it possible to enter backup and notification schedules in local time.

@dominicrutk dominicrutk added the bug Something isn't working label Jul 8, 2020
@dominicrutk
Copy link
Contributor Author

There are some modules such as timezone and moment that we might consider to reduce the complexity of this issue. However, we need to assess whether it's worth adding another dependency for something we could do ourselves or if reinventing the wheel would be worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dominicrutk