Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't rename hdf file when clipped #165

Open
slager opened this issue Jan 10, 2024 · 1 comment
Open

don't rename hdf file when clipped #165

slager opened this issue Jan 10, 2024 · 1 comment

Comments

@slager
Copy link
Contributor

slager commented Jan 10, 2024

Currently, if clipping occurs during preprocessing, the preprocessed hdf file has "_clip" appended before the extension. This requires special handling downstream in BirdFlowPipeline and BirdFlowPy.

This could potentially be removed and replaced with a metadata field inside the file indicating clipping status.

@ethanplunkett
Copy link
Contributor

I dropped "_clip" from the hdf file name in #166 however I still haven't added clip information to metadata.

  • Add clip information to metadata while preprocessing.
    • Flag to indicate that it is clipped
    • Possibly vector data on clipping polygon.
      • Do not use terra's vector format as it contains pointers/environments that will break things.
      • sf objects might be OK but I'd like to avoid any additional internal classes.
      • Possibly save the clip in raster (matrix) format with cells that align with the output projection?
      • Possibly save just the polygon's point coordinates in the final CRS - could get ugly with multi-part + holes.
      • Look to see if sf objects can be converted to standard data frame or matrix in a way that can easily be reversed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants