Skip to content

Commit afdff12

Browse files
committed
Bug 987282 - JSHint allow getter without setter globally r=julienw
1 parent 09c6960 commit afdff12

22 files changed

+3
-58
lines changed

.jshintrc

+3-1
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,7 @@
2626
"browser": true,
2727
"devel": true,
2828
"nonstandard": true,
29-
"worker": true
29+
"worker": true,
30+
31+
"-W078": true
3032
}

apps/calendar/test/marionette/lib/views/edit_event.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/*jshint -W078*/
21
'use strict';
32

43
var View = require('./view');

apps/communications/contacts/test/unit/export/generic_export_test.js

-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
/* global MockMozL10n */
88
/* global MocksHelper */
99

10-
/* Allow setter without getter */
11-
/* jshint -W078 */
12-
1310
requireApp('communications/contacts/test/unit/mock_navigation.js');
1411
requireApp('communications/contacts/test/unit/mock_contacts.js');
1512
requireApp('communications/contacts/test/unit/mock_mozContacts.js');

apps/communications/contacts/test/unit/export/sim_test.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
/* global ContactsSIMExport */
33
/* global MockMozContacts */
44

5-
/* Allow setter without getter */
6-
/* jshint -W078 */
7-
85
requireApp('communications/contacts/js/export/sim.js');
96
requireApp('communications/contacts/test/unit/mock_mozContacts.js');
107

apps/communications/contacts/test/unit/mock_fb.js

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
/* global MockContactAllFields */
55
/* global MockLinkedContacts */
66

7-
/* Allow setter without getter */
8-
/* jshint -W078 */
9-
107
var FB_ID = 220439;
118

129
var Mockfb = {

apps/communications/contacts/test/unit/mock_fb_data.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
'use strict';
2-
/* Allow setter without getter */
3-
/* jshint -W078 */
42

53
var MockFbContactsWriterObj = function() {
64
this.storedData = Object.create(null);

apps/communications/contacts/test/unit/mock_find_matcher.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
/* global SimplePhoneMatcher */
33
/* exported MockFindMatcher */
44

5-
/* Allow setter without getter */
6-
/* jshint -W078 */
7-
85
var MockFindMatcher = {
96
find: function(options) {
107
this.result = [];

apps/communications/contacts/test/unit/mock_get_device_storage.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22
/* exported MockgetDeviceStorage */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
74
var MockgetDeviceStorage = function() {
85
return {
96
'get': function(filepath) {

apps/communications/contacts/test/unit/mock_mozActivity.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
'use strict';
2-
/* Allow setter without getter */
3-
/* jshint -W078 */
42

53
function MockMozActivity(activity) {
64
MockMozActivity.calls.push(activity);

apps/communications/contacts/test/unit/mock_mozContacts.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
'use strict';
2-
/* Allow setter without getter */
3-
/* jshint -W078 */
42

53
var MockMozContacts;
64

apps/communications/contacts/test/unit/mock_sdcard.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22
/* exported MockSdCard */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
74
var MockSdCard = function MockSdCard() {
85

96
var observers = {};

apps/communications/contacts/test/unit/mock_sim_importer.js

-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
'use strict';
2-
/* Allow setter without getter */
3-
/* jshint -W078 */
42

53
var MockSimContactsImporter = function(n) {
64
this.number = n || 0;

apps/communications/contacts/test/unit/mock_value_selector.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22
/* exported ValueSelector */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
74
function ValueSelector() {
85
return {
96
data: {

apps/communications/contacts/test/unit/views/form_test.js

-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@
1212
/* global MockThumbnailImage */
1313
/* global utils */
1414

15-
/* Allow setter without getter */
16-
/* jshint -W078 */
17-
1815
require('/shared/test/unit/mocks/mock_contact_all_fields.js');
1916
require('/shared/js/text_normalizer.js');
2017
require('/shared/js/lazy_loader.js');

apps/search/test/unit/providers/contacts_test.js

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
/* global MocksHelper, MockMozContacts, MockContactsList, MockMozActivity,
33
Search */
44

5-
/* Allow setter without getter */
6-
/* jshint -W078 */
75
require('/shared/test/unit/mocks/mock_moz_activity.js');
86
require('/shared/js/url_helper.js');
97
requireApp('search/test/unit/mock_search.js');

shared/test/unit/mocks/mock_download_helper.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22
/* exported MockDownloadHelper */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
74
var MockDownloadHelper = {
85
open: function() {
96
return {

shared/test/unit/mocks/mock_fb_data_reader.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22
/* exported MockFbContacts */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
74
var MockFbContactsObj = function(result, inError) {
85
this.mResult = result;
96
this.inError = inError;

shared/test/unit/mocks/mock_icc_helper.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22
/* exported MockIccHelper */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
74
var MockIccHelper = {
85
mProps: {'cardState': null, 'iccInfo': {}, 'retryCount': 0},
96

shared/test/unit/mocks/mock_indexedDB.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
/* global sinon */
33
/* exported MockIndexedDB */
44

5-
/* Allow setter without getter */
6-
/* jshint -W078 */
7-
85
function MockIndexedDB() {
96
var transRequest = {};
107

shared/test/unit/mocks/mock_moz_activity.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
'use strict';
2-
/* Allow setter without getter */
3-
/* jshint -W078 */
4-
52

63
var MockMozActivity = function(info) {
74

shared/test/unit/mocks/mock_navigator_getdevicestorage.js

-4
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
'use strict';
22
/* exported MockGetDeviceStorage */
33

4-
/* Allow setter without getter */
5-
/* jshint -W078 */
6-
7-
84
var MockGetDeviceStorage = function() {
95
return {
106
get: function(filepath) {

shared/test/unit/mocks/mock_navigator_moz_downloads.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
/* global MockDownload */
33
/* exported MockMozDownloads */
44

5-
/* Allow setter without getter */
6-
/* jshint -W078 */
7-
85
/*
96
* This mockup needs to import as well:
107
* /shared/unit/tests/mock/mock_download.js

0 commit comments

Comments
 (0)