-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat+docu(EncFS): Deprecation warning in the GUI and details in whitepaper #1735
Comments
All of the three warnings are adequate IMHO. I just propose some small wording changes due to "typos":
Perhaps also the mode names could be improved to make it clear enough when
Esp. "SSH encrypted" is misleading IMHO because SSH is (transport) encrypted but what we mean here is "at rest" encryption. |
Thanks for the feedback.
Not sure about this. I would keep it as it is because the "support of encrypted backups" is a consequence of a "EncFS replacement". Or don't I get it? 😄
I support that idea. But I would work on that in a separate PR after the upcoming release. The code around that is quit awkward and I am not sure if there might be side effects with modifying that labels currently living in a dictionary ( |
I see 😄 I was just confused what the sentence shall mean but now I understand it. No need to change anything here I'd say.
Yes, this is the most fail-safe approach (no need to change year-old labels ASAP). PS: Just found a forgotten word in another sentence:
|
These notices, with the slight edits, look very good to me. I'm not using the feature, but I very much like the considerate approach for how to handle it. I wonder if maybe a link directly to #1734 in the notice would be worthwhile. |
I wouldn't pollute the messages with to much links and references. We do link the whitepaper. That document is good starting point to all other relevant documents (Issues, Security Audits, etc). The messages are for users, the issues are for developers. |
Now that I look at the whitepaper, I see it covers everything. |
I will take your comments as Approval, if it is OK. |
Related to meta issue #1734
Details and wording need to be discussed and developed.
The text was updated successfully, but these errors were encountered: