Problem with the .desktop file in the 1.5.4rc1

[hannes101]

Describe the problem, feature or ask a question:

I tried building the latest release candidate and I think the change of the desktop file(s) leads to errors. At least it's the case here in fedora.
Please see the following build log.

+ /usr/lib/rpm/find-lang.sh /home/johannes/rpmbuild/BUILD/backintime-1.5.4-build/BUILDROOT backintime
+ desktop-file-install --dir=/home/johannes/rpmbuild/BUILD/backintime-1.5.4-build/BUILDROOT/usr/share/applications /home/johannes/rpmbuild/BUILD/backintime-1.5.4-build/BUILDROOT/usr/share/applications/backintime-qt.desktop
/home/johannes/rpmbuild/BUILD/backintime-1.5.4-build/BUILDROOT/usr/share/applications/backintime-qt.desktop: error: value "NO" for boolean key "Terminal" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"
/home/johannes/rpmbuild/BUILD/backintime-1.5.4-build/BUILDROOT/usr/share/applications/backintime-qt.desktop: error: value "YES" for boolean key "StartupNotify" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"
Error on file "/home/johannes/rpmbuild/BUILD/backintime-1.5.4-build/BUILDROOT/usr/share/applications/backintime-qt.desktop": Failed to validate the created desktop file
error: Bad exit status from /var/tmp/rpm-tmp.qEt8fJ (%install)

RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.qEt8fJ (%install)

https://kojipkgs.fedoraproject.org//work/tasks/1275/129211275/build.log

[buhtz]

Thank you for testing and reporting.

Ah, I see. I misunderstood the specs for this file format.

I'll integrate the fix into PR #2035 . Can you temporary fix this on your site to step further?

EDIT: It seems you do have a linter running to check the desktop files. Which one is it?

[hannes101]

I fixed it, now there are again some test cases failing:
https://kojipkgs.fedoraproject.org//work/tasks/7562/129237562/build.log

The linter seems to be desktop-file-install from https://www.freedesktop.org/software/desktop-file-utils

[buhtz]

The test General.test_001_depency_workaround names it.
Your system uses PyFakeFS version 5.2.4, but it should be minimum 5.7.0 when used with Python 3.12.

=================================== FAILURES ===================================
_____________________ General.test_001_depency_workaround ______________________
self = <test.test_uniquenessset.General testMethod=test_001_depency_workaround>
    @unittest.skipIf(sys.version_info[:2] < (3, 12),
                     'Relevant only with Python 3.12 or newer (#1911)')
    def test_001_depency_workaround(self):
        """Workaround until #1575 is fixed.
    
        Python 3.13 needs PyFakeFS at min version 5.7
        Python 3.12 needs PyFakeFS at min version 5.6
    
        See: <https://github.com/bit-team/backintime/
             pull/1916#issuecomment-2438703637>
        """
        import pyfakefs
        pyfakefs_version = packaging.version.parse(pyfakefs.__version__)
        min_required_version = packaging.version.parse('5.7.0')
    
>       self.assertTrue(
            pyfakefs_version >= min_required_version,
            'With Python 3.12 or later the PyFakeFS version should be '
            f'minimum {min_required_version} '
            f'or later but is {pyfakefs_version}.')
E       AssertionError: False is not true : With Python 3.12 or later the PyFakeFS version should be minimum 5.7.0 or later but is 5.2.4.
test/test_uniquenessset.py:65: AssertionError

[hannes101]

Ok, sorry, could have read it more carefully. After getting this updated in fedora, the build works fine and everything looks good to me.