Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses should not contain transaction count field for block headers #24

Open
Danconnolly opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
bug Something isn't working deferred A change that is deferred until later.

Comments

@Danconnolly
Copy link
Contributor

Danconnolly commented Jun 5, 2023

See issue #18

It is not possible to determine the number of transactions in a block using SPV. To determine the number of transactions in a block using the existing P2P protocol, one would have to download the whole block. This would be inconsistent with the principles of SPV.

This field should not have been added to the result set. It will be removed. However, to do so would be a change in the API, so this change will only occur during the release of the next major version. This bug is in itself not enough to trigger the release of a new major version.

This ticket is a backlog item which should be implemented during the next major version update.

@Danconnolly Danconnolly added bug Something isn't working deferred A change that is deferred until later. labels Jun 5, 2023
@Danconnolly Danconnolly added this to the Major Release v3.0.0 milestone Jun 5, 2023
@Danconnolly
Copy link
Contributor Author

Actually, the newish enriched block header message might contain the information. Need to do more research.

@Danconnolly Danconnolly self-assigned this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deferred A change that is deferred until later.
Projects
None yet
Development

No branches or pull requests

1 participant