Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback for fader level comparison #19

Open
fmalcher opened this issue Nov 7, 2020 · 3 comments
Open

Add feedback for fader level comparison #19

fmalcher opened this issue Nov 7, 2020 · 3 comments

Comments

@fmalcher
Copy link
Collaborator

fmalcher commented Nov 7, 2020

First draft, not yet part of the module:

[FeedbackType.MasterChannelLevelCompare]: {
      label: 'Change colors for master channel level comparison',
      description: 'If fader level is greater/less than a given value, change color of the bank',
      options: [
        getBackgroundPicker(instance.rgb(0, 102, 0)),
        getForegroundPicker(instance.rgb(255, 255, 255)),
        ...OPTION_SETS.masterChannel,
        OPTIONS.faderValuesSlider,
        {
          type: 'dropdown',
          label: 'Compare',
          id: 'compare',
          choices: [
            { id: 1, label: 'greater than or equal' },
            { id: -1, label: 'less than or equal' }
          ],
          default: 1
        }
      ],
      callback: evt => {
        const compareValue = Number(evt.options.value);
        const faderValue = feedback.get(evt.id);
        const compareFactor = Number(evt.options.compare)
        if (faderValue * compareFactor >= compareValue) {
          return getOptColors(evt);
        } else {
          return {};
        }
      },
      subscribe: evt => {
        const c = getMasterChannelFromOptions(evt.options, conn);
        feedback.connect(evt, c.faderLevelDB$);
      },
      unsubscribe: evt => feedback.unsubscribe(evt.id)
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.90. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@fmalcher fmalcher changed the title Add feedback for fader levels Add feedback for fader level comparison Nov 29, 2020
@obbau
Copy link

obbau commented Nov 5, 2023

Is there any progress on this? I have a ui16 and really would like to have companion feedback to show the current fader level.

@fmalcher
Copy link
Collaborator Author

fmalcher commented Nov 5, 2023

No. These were the first experiments and I felt that feedbacks for a fader level comparison are not super useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants