Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Installation and Push to platform's domain folders #5085

Draft
wants to merge 1 commit into
base: platform/addison/PM-11129/installation-activity-column
Choose a base branch
from

Conversation

addisonbeck
Copy link
Contributor

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@addisonbeck addisonbeck changed the base branch from main to platform/addison/PM-11129/installation-activity-column November 26, 2024 00:35
@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch 2 times, most recently from 0517a00 to c785e42 Compare November 26, 2024 00:44
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.09%. Comparing base (84f7fa6) to head (15200dd).
Report is 2 commits behind head on platform/addison/PM-11129/installation-activity-column.

Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           platform/addison/PM-11129/installation-activity-column    #5085      +/-   ##
==========================================================================================
+ Coverage                                                   43.07%   43.09%   +0.02%     
==========================================================================================
  Files                                                        1417     1414       -3     
  Lines                                                       64852    64813      -39     
  Branches                                                     5927     5925       -2     
==========================================================================================
- Hits                                                        27934    27933       -1     
+ Misses                                                      35684    35646      -38     
  Partials                                                     1234     1234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Logo
Checkmarx One – Scan Summary & Details264184a0-41b7-4d4a-9e75-dd145c796b8e

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38
MEDIUM CSRF /src/Api/Controllers/PushController.cs: 38

@addisonbeck addisonbeck force-pushed the platform/addison/PM-11129/codeowners branch from c785e42 to 15200dd Compare November 26, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant