Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcing jupyter/bashrc needs to be robust #35

Open
robnagler opened this issue Jun 8, 2022 · 3 comments
Open

sourcing jupyter/bashrc needs to be robust #35

robnagler opened this issue Jun 8, 2022 · 3 comments
Milestone

Comments

@robnagler
Copy link
Member

robnagler commented Jun 8, 2022

Perhaps want to expand to all sourcing in ~/.bashrc so that you know which file has the error. If ~/juptyer/bashrc has an error, then keep going, because user has to get in to fix it. Need to notify user too.

@robnagler robnagler added this to the afcloud milestone Jun 8, 2022
@e-carlin
Copy link
Member

e-carlin commented Jul 6, 2022

Need to add pre_jupyter_bashrc too. We just had a user that couldn't get in due to a bug in that file.

@e-carlin
Copy link
Member

Had this happen again.

@robnagler
Copy link
Member Author

I think we need something like this in jupyter radia-run.sh

trap "handle_bashrc_err" EXIT
handle_bashrc_err() {
    move all custom bashrc out of the way
    check that we aren't in a loop with this by looking for the message on the next line
         if we are in a loop not sure what to do except log it to a file in the user's directory (JUPYTER_FAILURE) 
    put an echo in new jupyter/bashrc  that says we did this 
    exit
}

run the rest of the bashrc and right before exec do this
trap - EXIT

@robnagler robnagler changed the title sourcing jupyter/bashrc needs to be robust 20221231 sourcing jupyter/bashrc needs to be robust Oct 14, 2022
@robnagler robnagler changed the title 20221231 sourcing jupyter/bashrc needs to be robust sourcing jupyter/bashrc needs to be robust Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants