Skip to content

Commit 4f5854e

Browse files
gchtrjarednova
andauthored
Apply suggestions from code review
Commit Lukas's Markdown fixes Co-Authored-By: jarednova <[email protected]>
1 parent 67a97de commit 4f5854e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/SUPPORT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ Please post your question to Stack Overflow (http://stackoverflow.com/questions/
66

77
You can use [Gitter](https://gitter.im/timber/timber) for user-to-user support and help.
88

9-
Please don't post to the [WordPress.org support forum](https://wordpress.org/support/plugin/timber-library/). You might see a response, but it will just redirect you to either GitHub (for bugs/issues) or StackOverflow (for usage/support questions)
9+
Please don't post to the [WordPress.org support forum](https://wordpress.org/support/plugin/timber-library/). You might see a response, but it will just redirect you to either GitHub (for bugs/issues) or StackOverflow (for usage/support questions).

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,15 +266,15 @@ As soon as the todo is resolved, the `@todo` tag can be removed.
266266

267267
All PRs receive a review from at least one maintainer. We’ll do our best to do that review in a week, but we’d rather go slow and get it right than merge in code with issues that just lead to trouble.
268268

269-
#### GitHub reviews & assignments
269+
### GitHub reviews & assignments
270270

271271
You might see us assign multiple reviewers, in this case these are OR checks (i.e. either Coby or Pascal) unless we explicitly say it’s an AND type thing (i.e. can both Lukas and Maciej check this out?).
272272

273273
We use the assignee to show who’s responsible at that moment. We’ll assign back to the submitter if we need additional info/code/response, or it might be assigned to a branch maintainer if it needs more thought/revision (perhaps it’s directly related to an issue that's actively being worked on).
274274

275275
Once approved, the lead maintainer for the branch should merge the PR into the `master` or `2.x` branch. The 1.x team will work to resolve merge conflicts on #1617 (`2.x` into `master`) so the branches stay in sync.
276276

277-
#### Branch Maintainers
277+
### Branch Maintainers
278278

279279
* 1.x: @jaredNova (lead), @palmiak
280280
* 2.x: @gchtr (lead), @pascalknecht, @cobytamayo

0 commit comments

Comments
 (0)