Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft version integrity #17

Open
Flosus opened this issue Dec 31, 2016 · 3 comments
Open

Minecraft version integrity #17

Flosus opened this issue Dec 31, 2016 · 3 comments

Comments

@Flosus
Copy link
Contributor

Flosus commented Dec 31, 2016

While thinking about blocks, items and entitys i came to the conclusion that we may want to support multiple minecraft versions.

I thought that it would make sanity checks easier when we add an Annotation like MinecraftVersion to blocks, items and such. This annotation would contain the release version of the Type.

In the light of the recent changes about names instead of IDs I also would like you to take a look at the Minecraft 1.11 changelog. There are changes listed for blocknames. E.g. Cauldron got changed to brewing_stand. Any ideas how to keep compatibility or do you think it will be easier to just release multiple minecraft.client libs for different server versions? This might make a MinecraftVersion annotation obsolete.

@bleroy
Copy link
Owner

bleroy commented Jan 3, 2017

Interesting. Thanks for pointing that out. Supporting multiple versions has always been the plan, but what I had in mind was the latest of Java, Pocket, and Win10, and maybe some specifics about popular servers. Supporting older versions rather than only latest sounds too much, but we probably will have to be able to optionally annotate names with the versions they appeared in. Maybe allow for multiple name attributes, something like: [Name("brewing_stand", "JavaMinecraft", "1.11"]?

@beppe9000
Copy link

can't the block be scraped from the currently running client?

@bleroy
Copy link
Owner

bleroy commented May 15, 2018

What do you mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants