Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed to ephemeral shard returns following security review of ssb-ephemeral-keys #56

Open
ameba23 opened this issue May 13, 2019 · 11 comments

Comments

@ameba23
Copy link
Member

ameba23 commented May 13, 2019

Since adding functionality for ephemeral shard returns, the module ssb-ehemeral-keys has had a security review which meant it needed to be changed significantly:

ssbc/ssb-ephemeral-keys#8
ssbc/ssb-ephemeral-keys#7
ssbc/ssb-ephemeral-keys#6

The modifications to ssb-ephemeral-keys must still be completed, and this module needs to be updated to account for these changes.

Consideration but be taken as to what to use as a database key for storing the ephemeral keys. Due to concerns with not being able to securely remove data from leveldb, keys are now stored as flat files. Because of this, json objects can no longer be used as a database key, so another solution is needed.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1000.0 DAI (1000.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) sagarjethi has applied to start work (Funders only: approve worker | reject worker).

I have check that issuse. I have local install this repo and finding solving. i have debugged code find solution

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

gitcoinbot commented Jun 1, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months, 1 week from now.
Please review their action plans below:

1) sagarjethi has applied to start work (Funders only: approve worker | reject worker).

I have check that issuse. I have local install this repo and finding solving. i have debugged code find solution
2) ameba23 has been approved to start work.

  • Respond to the changes made to ssb-ephemeral-keys in the relevant PRs.
  • Decide on an appropriate form for a database key for storing ephemeral keys.
  • Update this module according to the changes in the form and functionality of the methods of ssb-ephemeral-keys

Learn more on the Gitcoin Issue Details page.

@aahutsal
Copy link

aahutsal commented Jun 8, 2019

is it still actual, @ameba23 ?

@gitcoinbot
Copy link

@ameba23 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@ameba23
Copy link
Member Author

ameba23 commented Jun 11, 2019

@gitcoinbot work has begun.

@gitcoinbot
Copy link

@ameba23 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@ameba23 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@ameba23
Copy link
Member Author

ameba23 commented Jun 21, 2019

@gitcoinbot yes still working

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1000.0 DAI (1000.0 USD @ $1.0/DAI) has been submitted by:

  1. @ameba23

@ceresstation please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 1000.0 DAI (1000.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @ameba23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants