Skip to content
This repository was archived by the owner on Dec 1, 2021. It is now read-only.

Improve code quality of output_template #1152

Open
hadusam opened this issue Aug 3, 2020 · 0 comments
Open

Improve code quality of output_template #1152

hadusam opened this issue Aug 3, 2020 · 0 comments

Comments

@hadusam
Copy link
Contributor

hadusam commented Aug 3, 2020

No tests

There is no tests for output_template/python except run.py of e2e test.
It is better to add tests as well as other python files (e.g. under blueoil/).

Redundant codes

usb_camera_demo.py and motion_jpeg_server_from_camera.py are demo scripts and internal logic is similar but there are redundant implementation about visualization and measure inference time(fps). And run.py has also function to measure inference time.
I think there is some better way to improve readability of these codes.

@hadusam hadusam changed the title Improve code quality in output_template Improve code quality of output_template Aug 3, 2020
bo-mergebot bot pushed a commit that referenced this issue Aug 3, 2020
## What this patch does to fix the issue.
A part of #1152 

## Link to any relevant issues or pull requests.
bo-mergebot bot pushed a commit that referenced this issue Aug 19, 2020
…1155)

## What this patch does to fix the issue.
A part of #1152 

* add Dockerfile for inference
* add test-unit-inference to Makefile
* add test-unit-inference to buildkite pipeline
* add a small test for run.py to check test environment works well (I am planning to add more tests after this PR)

## Link to any relevant issues or pull requests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant