Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: migrate from call local refund to global journal refund #2145

Open
rakita opened this issue Mar 5, 2025 · 0 comments
Open

Refactor: migrate from call local refund to global journal refund #2145

rakita opened this issue Mar 5, 2025 · 0 comments

Comments

@rakita
Copy link
Member

rakita commented Mar 5, 2025

Presently, refund is call local and returned back with the gas when the call is finished, this can result in negative refund being returned and is a unexpected value for tracing.

Having one global refund inside the journal would mitigate this, on the one hand, it will slighlty leak gas calc into journal that is database, but on other hand it (should) encapsulate any refund inside of it additionally removing negative refund case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant