Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Fatal error on bls precompiles if in no_std #2208

Open
rakita opened this issue Mar 13, 2025 · 3 comments
Open

Return Fatal error on bls precompiles if in no_std #2208

rakita opened this issue Mar 13, 2025 · 3 comments
Labels
good first issue Good for newcomers

Comments

@rakita
Copy link
Member

rakita commented Mar 13, 2025

Blst does not have a no_std variant. Pending task for support is made here: #2172

Until that task is done, we should return PrecompileError::Fatal error for any bls precompiles. Similar to this

let precompile = PrecompileWithAddress(u64_to_address(0x0A), |_,_| Err(PrecompileError::Fatal("c-kzg feature is not enabled".into())));

All precompiles are here:

pub fn precompiles() -> impl Iterator<Item = PrecompileWithAddress> {

@Ayushdubey86
Copy link
Contributor

looking into this! but will this be redundant after #2172 ?

@rakita
Copy link
Member Author

rakita commented Mar 13, 2025

#2172 is bigger task, so until it is implemented, it would be good to have this PR.

@Ayushdubey86
Copy link
Contributor

Raised a dummy pr. do check this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants