You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The DepositTransaction trait contains a fn source_hash(&self) -> B256; to retrieve the source hash of an OP deposit transaction.
This trait is implemented for the overall OpTransaction, which means that I can also call transaction.source_hash() if transaction is an OpTransaction for e.g. a blob transaction.
This made me wonder whether it wouldn't be better for the API to be:
fnsource_hash(&self) -> Option<&B256>
since that would signal whether the transaction has a source hash (only true for deposit transaction).
WDYT, @rakita? If you agree, I can implement this change.
The text was updated successfully, but these errors were encountered:
The
DepositTransaction
trait contains afn source_hash(&self) -> B256;
to retrieve the source hash of an OP deposit transaction.This trait is implemented for the overall
OpTransaction
, which means that I can also calltransaction.source_hash()
iftransaction
is anOpTransaction
for e.g. a blob transaction.This made me wonder whether it wouldn't be better for the API to be:
since that would signal whether the transaction has a source hash (only true for deposit transaction).
WDYT, @rakita? If you agree, I can implement this change.
The text was updated successfully, but these errors were encountered: