Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeOnSlideClick not work with blueimp-gallery-contain #259

Open
leadenhead opened this issue Feb 22, 2021 · 1 comment
Open

closeOnSlideClick not work with blueimp-gallery-contain #259

leadenhead opened this issue Feb 22, 2021 · 1 comment

Comments

@leadenhead
Copy link

Hello!
Actually, I found this behavior:
closeOnSlideClick: true not work with blueimp-gallery-contain
Is this a bug or should it be?
Thanks!

@blueimp
Copy link
Owner

blueimp commented Sep 25, 2021

It's an implementation detail. 😬

The CSS code applied to images with this class sets the img element dimensions to the full size of the container (even though the actual image is not necessarily covering the whole container):

width: 100%;
height: 100%;
object-fit: contain;

Since the click on the image itself is already reserved to toggle the display of the controls, I'm not sure how to fix this easily unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants