Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would you accept a Pull Request Adding CodeCov (test coverage) ? #43

Open
nelsonic opened this issue Nov 9, 2015 · 3 comments
Open

Would you accept a Pull Request Adding CodeCov (test coverage) ? #43

nelsonic opened this issue Nov 9, 2015 · 3 comments

Comments

@nelsonic
Copy link
Contributor

nelsonic commented Nov 9, 2015

Hi @boennemann,
Can I add https://codecov.io/#features to the list in the
Test Coverage Section: https://github.com/boennemann/badges#test-coverage ?
@boennemann
Copy link
Owner

Yes please :)

nelsonic added a commit to nelsonic/badges that referenced this issue Nov 9, 2015
@nelsonic
adds Codecov.io badge Readme.md and before/after script in .travis.ym…
fd6536a 
…l as discussed in: boennemann#43
@nelsonic
Copy link
Contributor Author

nelsonic commented Nov 9, 2015

Hi @boennemann
I've added the badge to the Readme: codecov.io
also added a before/after script to .travis.yml to send the lcov.info (coverage report) to Codecov

The badge currently points to: https://codecov.io/github/nelsonic/badges
(I was just confirming it would work with your build before submitting PR...)
Travis works as expected: https://travis-ci.org/nelsonic/badges/builds/90089746

I will change the badge to point to your repo but you will need to sign into https://codecov.io/github/boennemann/badges to activate it.
Then when you merge the Pull Request it the badge will magically work...

nelsonic added a commit to nelsonic/badges that referenced this issue Nov 9, 2015
@nelsonic
update badge url to /boennemann as discussed in: boennemann#43 (comment)
6e22f0d
@nelsonic nelsonic mentioned this issue Nov 9, 2015
Merged
@nelsonic
Copy link
Contributor Author

nelsonic commented Nov 9, 2015

Changed the badge to your repo. codecov.io

stupidscammer pushed a commit to stupidscammer/badges that referenced this issue Mar 19, 2023
adds Codecov.io badge Readme.md and before/after script in .travis.ym…
4a590de 
…l as discussed in: boennemann/badges#43
stupidscammer pushed a commit to stupidscammer/badges that referenced this issue Mar 19, 2023
update badge url to /boennemann as discussed in: boennemann/badges#43…
2e08bae 
… (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @boennemann