Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GenerationOptions #17

Open
vanillajonathan opened this issue Jul 22, 2020 · 2 comments
Open

Move GenerationOptions #17

vanillajonathan opened this issue Jul 22, 2020 · 2 comments
Assignees

Comments

@vanillajonathan
Copy link
Contributor

Move /Configuration/GenerationOptions.cs to /GenerationOptions.cs. Moving it away from a separate directory into the source root eases discoverability of the class.

Change the namespace from "shortid.Configuration" to "shortid".

@detach8
Copy link

detach8 commented May 10, 2021

I second this, and would also recommend changing class to ShortIdOptions or something more unique to the project.

@bolorundurowb
Copy link
Owner

I guess the community has spoken, I'll mark the GenerationOptions class as obsolete and update the naming in the next major release. Thanks for the feedback @vanillajonathan and @detach8

@bolorundurowb bolorundurowb self-assigned this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants