Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MyPage/aos] 로그아웃, 회원 탈퇴 후 화면 전환 #117

Merged

Conversation

yy0ung
Copy link
Collaborator

@yy0ung yy0ung commented Nov 25, 2023

주요 작업

  • intent flag 설정하여 IntroActivity 로 전환 로직 수정
  • 회원 탈퇴 시 unlink 구현
  • BearerInterceptor 에서 access token 재발급 실패 시 IntroActivity 로 전환

완료한 task 명세

  • 회원 탈퇴 시 네이버 로그인 unlink
  • IntroActivity 로의 화면 전환

결과 화면

리뷰 요청 사항

  • BearerInterceptor 에서는 applicationContext 사용하는 로직을 일단 구현했는데 리뷰 부탁!!
  • issue 에는 로그아웃/회원 탈퇴 모두 unlink task 가 있는데 로그아웃에서는 unlink 안하는게 자연스러운 것 같아서 구현 제외했어. 혹시 추가해야 할 것 같으면 말해줘!

related to issue #22
related to issue #23
related to issue #86

@yy0ung yy0ung added feat 기능 구현 AOS 작업범위 : Android labels Nov 25, 2023
@yy0ung yy0ung added this to the 마이페이지 milestone Nov 25, 2023
@yy0ung yy0ung requested review from BENDENG1 and plashdof November 25, 2023 12:49
@yy0ung yy0ung self-assigned this Nov 25, 2023
Copy link
Collaborator

@BENDENG1 BENDENG1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍

@@ -43,6 +45,15 @@ class MyPageRepositoryImpl @Inject constructor(
is BaseState.Success -> {
dataStoreManager.deleteAccessToken()
dataStoreManager.deleteRefreshToken()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 autoLogin도 지우는게 나을 것 같아!

val intent = Intent(context, IntroActivity::class.java)
intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_CLEAR_TASK
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@plashdof plashdof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

군더더기 없군요!

@plashdof plashdof merged commit 7ba9643 into boostcampwm2023:feature/aos-mypage Nov 26, 2023
@yy0ung yy0ung deleted the feature/aos-mypage branch November 27, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AOS 작업범위 : Android feat 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants