Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/scoreboard/UI : ScoreBoard UI #100

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Feat/scoreboard/UI : ScoreBoard UI #100

merged 3 commits into from
Nov 28, 2023

Conversation

glowisn
Copy link
Collaborator

@glowisn glowisn commented Nov 28, 2023

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?
  • Remove: print나 주석 등 필요없는 코드를 삭제했나요?

Description

스코어보드 모달창 UI를 만들었습니다.

Changes Made

client/public/mocks/Scores.json : ScoreBoard Mock data
client/src/components/ScoreBoardModal/*.tsx : 스코어보드 UI
client/src/routes.tsx : 임시 라우터 추가, 추후 모달화 되면 삭제
client/src/types/ScoreType.ts : 점수 타입 선언

Extra Comments

Demo

image
초록색 체크가 좀 안보이는 거 같은데 배경색이나 초록색 중 하나를 바꾸면 좋을 것 같네요

@glowisn glowisn requested review from kiuuon and Lukaid-dev November 28, 2023 01:19
@glowisn glowisn self-assigned this Nov 28, 2023
Copy link
Collaborator

@kiuuon kiuuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glowisn glowisn merged commit e027ab1 into develop Nov 28, 2023
1 check passed
@glowisn glowisn deleted the feat/scoreboard/ui branch November 28, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants