Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: server 배포에서 돌아가도록 핫 픽스: 프론트 env 파일, auth callback url 관련 픽스 #106

Closed
wants to merge 1 commit into from

Conversation

vimkim
Copy link
Collaborator

@vimkim vimkim commented Nov 28, 2023

Description

배포 서버에서 정상적으로 돌아가기 위해

  • OAuth callback URL을 바꿔준다.
  • localhost -> baekjoon.com 으로 바꿔서 CORS를 열어준다.
  • client의 .dockreignore에서 .env를 이미지에 포함할 수 있도록 바꿔준다. 이유: vite는 빌드 타임에 .env를 상수로 바꾸고, runtime에 불러오지 않는다.

@vimkim vimkim requested review from sjn0910 and Lukaid-dev November 28, 2023 11:32
Copy link
Collaborator

@sjn0910 sjn0910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 이제 실제로 배포되면 로그인이 되겠네용!

Copy link
Collaborator

@Lukaid-dev Lukaid-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Fake Login 달면 이렇게 진행해도 좋을 것 같습니다

@vimkim vimkim marked this pull request as draft November 29, 2023 06:06
@vimkim
Copy link
Collaborator Author

vimkim commented Dec 1, 2023

해당 풀 리퀘는 #130 에서 더 나은 버전으로 패치되었으므로 머지 없이 닫습니다.

@vimkim vimkim closed this Dec 1, 2023
@sjn0910 sjn0910 deleted the fix/cors-hotfix branch December 5, 2023 16:56
@sjn0910 sjn0910 restored the fix/cors-hotfix branch December 5, 2023 16:56
@sjn0910 sjn0910 deleted the fix/cors-hotfix branch December 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants