Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/scoreboard/UI adv : 스코어보드 API 연동 #209

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

glowisn
Copy link
Collaborator

@glowisn glowisn commented Dec 11, 2023

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?

Description

스코어보드 API 형태에 따라 UI를 렌더링 하도록 했습니다.

Changes Made

client/src/apis/scores.ts : 스코어보드 API 호출
client/src/types/Score.ts : 스코어 타입

Extra Comments

스타트로 roomInfo 내의 problems를 바꿔야 현재 UI가 확인 가능함.
(roomInfo내의 playerName과 problemId가 같아야 렌더링이 됨)

@glowisn glowisn self-assigned this Dec 11, 2023
@glowisn glowisn requested review from Lukaid-dev and kiuuon December 11, 2023 10:34
@glowisn glowisn marked this pull request as ready for review December 11, 2023 10:38
Copy link
Collaborator

@kiuuon kiuuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Lukaid-dev Lukaid-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 코드상으로는 좋아보입니다. 머지 후 시연 빠르게 해봅시다.

@glowisn glowisn merged commit 75d6112 into develop Dec 12, 2023
1 check passed
@glowisn glowisn deleted the feat/scoreboard/UI-adv branch December 12, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants