hotfix(dynamic-query): dynamic 쿼리 제거 #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjn0910
approved these changes
Dec 12, 2023
crongro
reviewed
Dec 12, 2023
| for (const bojProblemId of bojProblemIds) { | ||
| const problem = await this.getProblemByBojProblemId(bojProblemId); | ||
| if (problem == null) { | ||
| throw new Error(`bojProblemId ${bojProblemId} not found`); |
There was a problem hiding this comment.
참고.
반복문 안에 await를 사용할때는 병렬인지, 직렬인지 잘 확인해보시면 좋죠.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
위 에러를 해결했습니다..
다이내믹 쿼리는 안 쓰는 게 좋다는 교훈을 얻었습니다.
빠른 테스트를 위해 포문 돌렸습니다...