Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:ranking-UI #283

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat:ranking-UI #283

merged 2 commits into from
Mar 8, 2024

Conversation

glowisn
Copy link
Collaborator

@glowisn glowisn commented Feb 12, 2024

Checklist

  • Code Review: 작성한 코드를 다시 한 번 꼼꼼이 확인했나요?
  • Testing: 앱이 잘 구동되는지 개발한 기능이 문제 없이 작동하는지 확인했나요?
  • Remove: print나 주석 등 필요없는 코드를 삭제했나요?

Description

랭킹 API를 스코어보드에 적용했습니다.

Changes Made

Extra Comments

UI는 잘 나오는 것 같은데, ranking이 잘 반영되는지는 mock으로는 테스트가 어려워 일단 PR을 올립니다.

Demo

image

@glowisn glowisn requested a review from kiuuon February 12, 2024 13:34
@glowisn glowisn self-assigned this Feb 12, 2024
@glowisn glowisn linked an issue Feb 12, 2024 that may be closed by this pull request
1 task
@glowisn glowisn requested a review from Lukaid-dev February 29, 2024 01:46
@glowisn glowisn merged commit b29dd94 into main Mar 8, 2024
1 check passed
@glowisn glowisn deleted the feat/RankingUI branch March 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat : 스코어보드 API 적용 UI 개발
3 participants