-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/UI room setting #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 컨플릭트만 잡았는데 기원님 리뷰 받으시고 머지하시면 될 거 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고가 많으셔요~ 화이팅~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Checklist
Description
Room쪽 ui및 로직 다수 수정했습니다. 추가적으로 방 안에서 문제들 가져오는 로직은 웹소켓에 조금 더 적응 되고 다시 보겠습니다. 내일 같이 얘기해보면서 소켓 붙여봐야 알거같아요
Changes Made
Extra Comments
UI를 좀 많이 손댔습니다. 제 생각에 편할 것 같은 방향으로 수정했는데 피드백 환영입니다.
추가적으로 룸 안에서 문제추가 로직과 해당 문제로 라우트해주는 기능이 혼재되어있는데 이것도 내일 이후에 수정, 추가 하겠습니다.
Demo
2023-11-27.11.26.13.mov