Skip to content

Sysusers lint does not meet specification #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
M-Pixel opened this issue May 25, 2025 · 1 comment · Fixed by #1332
Closed

Sysusers lint does not meet specification #1331

M-Pixel opened this issue May 25, 2025 · 1 comment · Fixed by #1332
Labels
area/sysusers-tmpfiles Issues related to sysusers, uid/gid or tmpfiles.d bug Something isn't working triaged This looks like a valid issue

Comments

@M-Pixel
Copy link

M-Pixel commented May 25, 2025 •
edited
Loading

bootc lint fails in ways that systemd itself does not when run on a system with files that contain certain features (here is the systemd specification).

  • fails to parse when a /file/owned/by/user (or group) path is provided instead of a number or dash.
  • ignores lines that begin with u!, instead of treating the same as u
  • fails to parse u lines that leave GECOS field unset instead of explicitly defaulting it with -
@cgwalters cgwalters added bug Something isn't working triaged This looks like a valid issue area/sysusers-tmpfiles Issues related to sysusers, uid/gid or tmpfiles.d labels May 27, 2025
cgwalters added a commit to cgwalters/bootc that referenced this issue May 27, 2025
@cgwalters
sysusers: Parse 'u!'
ab827f5 
This was added in newer systemd.

xref: bootc-dev#1331
Signed-off-by: Colin Walters <[email protected]>
cgwalters added a commit to cgwalters/bootc that referenced this issue May 27, 2025
@cgwalters
sysusers: Parse path references too
6da8c2f 
These are uncommon, but valid.

xref: bootc-dev#1331
Signed-off-by: Colin Walters <[email protected]>
cgwalters added a commit to cgwalters/bootc that referenced this issue May 27, 2025
@cgwalters
sysusers: Also verify parsing of other entry types
bd317c3 
xref bootc-dev#1331
@cgwalters cgwalters mentioned this issue May 27, 2025
Merged
@cgwalters
Copy link
Collaborator

Thanks for the report; PR in #1332

cgwalters added a commit to cgwalters/bootc that referenced this issue May 27, 2025
@cgwalters
sysusers: Parse more truncated entries
5961d29 
This isn't mentioned in the docs, but the tooling
will happily accept missing GECOS or even the uid field
for users.

xref bootc-dev#1331

Signed-off-by: Colin Walters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/sysusers-tmpfiles Issues related to sysusers, uid/gid or tmpfiles.d bug Something isn't working triaged This looks like a valid issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sysusers: Various fixes cgwalters/bootc
2 participants
@cgwalters @M-Pixel