Revert "turn all warnings into errors but ignore type punning for fra…

…nka_hardware" This reverts commit b1b5158.
boschresearch · Dec 5, 2024 · e64aff2 · e64aff2
1 parent 18b416e
commit e64aff2
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 9 deletions.
diff --git a/franka_example_controllers/CMakeLists.txt b/franka_example_controllers/CMakeLists.txt
@@ -8,7 +8,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
+    add_compile_options(-Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/franka_gripper/CMakeLists.txt b/franka_gripper/CMakeLists.txt
@@ -6,7 +6,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
+    add_compile_options(-Wall -Wextra -Wpedantic)
 endif()
 
 find_package(ament_cmake REQUIRED)

diff --git a/franka_hardware/CMakeLists.txt b/franka_hardware/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Werror -Wall -Wextra -Wpedantic)
+  add_compile_options(-Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/franka_hardware/test/CMakeLists.txt b/franka_hardware/test/CMakeLists.txt
@@ -7,6 +7,3 @@ target_link_libraries(${PROJECT_NAME}_test  ${PROJECT_NAME})
 if(${hardware_interface_VERSION} VERSION_GREATER_EQUAL "4.20")
     target_compile_definitions(${PROJECT_NAME}_test PRIVATE HW_HAS_GET_BY_REF)
 endif()
-
-# ignore type punning via 'reinterpret_cast<double*>(&[...])'
-target_compile_options(${PROJECT_NAME}_test PRIVATE -Wno-error=strict-aliasing)
diff --git a/franka_robot_state_broadcaster/CMakeLists.txt b/franka_robot_state_broadcaster/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
+    add_compile_options(-Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/franka_semantic_components/CMakeLists.txt b/franka_semantic_components/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Werror -Wall -Wextra -Wpedantic)
+  add_compile_options(-Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/integration_launch_testing/CMakeLists.txt b/integration_launch_testing/CMakeLists.txt
@@ -8,7 +8,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
+    add_compile_options(-Wall -Wextra -Wpedantic)
 endif()
 
 # find dependencies