From a753a23ed698c4b2721a2abaa64e3b54ed33b1db Mon Sep 17 00:00:00 2001 From: Ryan England Date: Sat, 4 May 2019 20:07:54 +0100 Subject: [PATCH 1/2] Update with latest set of quotes from Laravel 5.8 The testConversationBasicTest seemingly randomly fails. This is due to two additional quotes in the Laravel Inspire package that haven't been incorporated into this test yet. When either of those two additional quotes are returned, the test files. --- tests/BotMan/ExampleTest.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/BotMan/ExampleTest.php b/tests/BotMan/ExampleTest.php index 883fa29..a4c5d53 100644 --- a/tests/BotMan/ExampleTest.php +++ b/tests/BotMan/ExampleTest.php @@ -38,6 +38,8 @@ public function testConversationBasicTest() 'It is quality rather than quantity that matters. - Lucius Annaeus Seneca', 'Genius is one percent inspiration and ninety-nine percent perspiration. - Thomas Edison', 'Computer science is no more about computers than astronomy is about telescopes. - Edsger Dijkstra', + 'It always seems impossible until it is done. - Nelson Mandela', + 'Act only according to that maxim whereby you can, at the same time, will that it should become a universal law. - Immanuel Kant', ]; $this->bot From ba3b8a56d2ac8be2b322c5ea08015aced20d7e56 Mon Sep 17 00:00:00 2001 From: Ryan England Date: Sat, 4 May 2019 20:12:55 +0100 Subject: [PATCH 2/2] Remove unused namepace according to StyleCI StyleCI required removal of this unused namespace. --- tests/BotMan/ExampleTest.php | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/BotMan/ExampleTest.php b/tests/BotMan/ExampleTest.php index a4c5d53..b11cf47 100644 --- a/tests/BotMan/ExampleTest.php +++ b/tests/BotMan/ExampleTest.php @@ -2,7 +2,6 @@ namespace Tests\BotMan; -use Illuminate\Foundation\Inspiring; use Tests\TestCase; class ExampleTest extends TestCase