Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLM policies UI schema #3352

Open
wants to merge 45 commits into
base: chatui
Choose a base branch
from
Open

LLM policies UI schema #3352

wants to merge 45 commits into from

Conversation

pi1814
Copy link

@pi1814 pi1814 commented Nov 21, 2024 •
edited
Loading

What does this PR do?

Adds UI Schema for LLM policies

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

dependabot bot and others added 22 commits November 14, 2024 12:30
@dependabot
Bump the aws-sdk group in /npm with 3 updates (#3333)
a7b667d 
Bumps the aws-sdk group in /npm with 3 updates: [@aws-sdk/client-dynamodb](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-dynamodb), [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers) and [@aws-sdk/util-dynamodb](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/util-dynamodb).


Updates `@aws-sdk/client-dynamodb` from 3.687.0 to 3.691.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-dynamodb/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.691.0/clients/client-dynamodb)

Updates `@aws-sdk/credential-providers` from 3.687.0 to 3.691.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.691.0/packages/credential-providers)

Updates `@aws-sdk/util-dynamodb` from 3.689.0 to 3.691.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/util-dynamodb/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.691.0/packages/util-dynamodb)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-dynamodb"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: "@aws-sdk/credential-providers"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: "@aws-sdk/util-dynamodb"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @rollup/rollup-linux-x64-gnu from 4.25.0 to 4.26.0 in /internal-…
17d5918 
…ui (#3332)

Bumps [@rollup/rollup-linux-x64-gnu](https://github.com/rollup/rollup) from 4.25.0 to 4.26.0.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.25.0...v4.26.0)

---
updated-dependencies:
- dependency-name: "@rollup/rollup-linux-x64-gnu"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@deepakprabhakara
cleaned up pii policy and llm config apis
edd4591
@dependabot
Bump eslint from 9.14.0 to 9.15.0 in /internal-ui (#3338)
17bca1c 
Bumps [eslint](https://github.com/eslint/eslint) from 9.14.0 to 9.15.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.14.0...v9.15.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump the aws-sdk group in /npm with 3 updates (#3336)
02fb5ab 
Bumps the aws-sdk group in /npm with 3 updates: [@aws-sdk/client-dynamodb](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-dynamodb), [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers) and [@aws-sdk/util-dynamodb](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/util-dynamodb).


Updates `@aws-sdk/client-dynamodb` from 3.691.0 to 3.693.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-dynamodb/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.693.0/clients/client-dynamodb)

Updates `@aws-sdk/credential-providers` from 3.691.0 to 3.693.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.693.0/packages/credential-providers)

Updates `@aws-sdk/util-dynamodb` from 3.691.0 to 3.693.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/util-dynamodb/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.693.0/packages/util-dynamodb)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-dynamodb"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: "@aws-sdk/credential-providers"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: "@aws-sdk/util-dynamodb"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump tailwindcss from 3.4.14 to 3.4.15 (#3335)
279a68d 
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.4.14 to 3.4.15.
- [Release notes](https://github.com/tailwindlabs/tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/v3.4.15/CHANGELOG.md)
- [Commits](tailwindlabs/tailwindcss@v3.4.14...v3.4.15)

---
updated-dependencies:
- dependency-name: tailwindcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@niwsa
API fixes for v1 endpoints (#3334)
d3529e3 
* Normalize param in api route paths

* Also normalize `dsync.log_webhook_events`

* entityId check should happen only for type saml

* Fallback to true for unexpected values

* Check existing length before deletion

* Normalize a few more params

* Add `forceAuthn` param to swagger

* Fixes for dsync swagger

* Fix sso swagger add clear descriptions
@dependabot
Bump cross-spawn from 7.0.3 to 7.0.6 in /npm (#3340)
3b937a6 
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @rollup/rollup-linux-x64-gnu from 4.26.0 to 4.27.3 in /internal-…
57c15a6 
…ui (#3341)

Bumps [@rollup/rollup-linux-x64-gnu](https://github.com/rollup/rollup) from 4.26.0 to 4.27.3.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.26.0...v4.27.3)

---
updated-dependencies:
- dependency-name: "@rollup/rollup-linux-x64-gnu"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump the typescript-eslint group in /internal-ui with 2 updates (#3344)
c5446f2 
Bumps the typescript-eslint group in /internal-ui with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser).


Updates `@typescript-eslint/eslint-plugin` from 8.14.0 to 8.15.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.15.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.14.0 to 8.15.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.15.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @playwright/test from 1.48.2 to 1.49.0 (#3343)
d59af0e 
Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.48.2 to 1.49.0.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.48.2...v1.49.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @heroicons/react from 2.1.5 to 2.2.0 (#3342)
a8278cf 
Bumps [@heroicons/react](https://github.com/tailwindlabs/heroicons) from 2.1.5 to 2.2.0.
- [Release notes](https://github.com/tailwindlabs/heroicons/releases)
- [Changelog](https://github.com/tailwindlabs/heroicons/blob/master/CHANGELOG.md)
- [Commits](tailwindlabs/heroicons@v2.1.5...v2.2.0)

---
updated-dependencies:
- dependency-name: "@heroicons/react"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Initial commit for the LLM Policies UI Schema
3868089
Renaming 'policy_settings' to 'policies'
052dbf8
@dependabot
Bump vite-tsconfig-paths from 5.1.2 to 5.1.3 in /internal-ui (#3350)
1c04c43 
Bumps [vite-tsconfig-paths](https://github.com/aleclarson/vite-tsconfig-paths) from 5.1.2 to 5.1.3.
- [Release notes](https://github.com/aleclarson/vite-tsconfig-paths/releases)
- [Commits](aleclarson/vite-tsconfig-paths@v5.1.2...v5.1.3)

---
updated-dependencies:
- dependency-name: vite-tsconfig-paths
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @types/node from 22.9.0 to 22.9.1 in /internal-ui (#3349)
fd10af0 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.9.0 to 22.9.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @types/node from 22.9.0 to 22.9.1 in /npm (#3348)
14b21cd 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.9.0 to 22.9.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump the aws-sdk group in /npm with 3 updates (#3347)
52c6c52 
Bumps the aws-sdk group in /npm with 3 updates: [@aws-sdk/client-dynamodb](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-dynamodb), [@aws-sdk/credential-providers](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/credential-providers) and [@aws-sdk/util-dynamodb](https://github.com/aws/aws-sdk-js-v3/tree/HEAD/packages/util-dynamodb).


Updates `@aws-sdk/client-dynamodb` from 3.693.0 to 3.696.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-dynamodb/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.696.0/clients/client-dynamodb)

Updates `@aws-sdk/credential-providers` from 3.693.0 to 3.696.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/credential-providers/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.696.0/packages/credential-providers)

Updates `@aws-sdk/util-dynamodb` from 3.693.0 to 3.696.0
- [Release notes](https://github.com/aws/aws-sdk-js-v3/releases)
- [Changelog](https://github.com/aws/aws-sdk-js-v3/blob/main/packages/util-dynamodb/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-js-v3/commits/v3.696.0/packages/util-dynamodb)

---
updated-dependencies:
- dependency-name: "@aws-sdk/client-dynamodb"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: "@aws-sdk/credential-providers"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
- dependency-name: "@aws-sdk/util-dynamodb"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: aws-sdk
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump prettier-plugin-tailwindcss from 0.6.8 to 0.6.9 (#3346)
7e47830 
Bumps [prettier-plugin-tailwindcss](https://github.com/tailwindlabs/prettier-plugin-tailwindcss) from 0.6.8 to 0.6.9.
- [Release notes](https://github.com/tailwindlabs/prettier-plugin-tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/prettier-plugin-tailwindcss/blob/main/CHANGELOG.md)
- [Commits](tailwindlabs/prettier-plugin-tailwindcss@v0.6.8...v0.6.9)

---
updated-dependencies:
- dependency-name: prettier-plugin-tailwindcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump i18next from 23.16.5 to 23.16.6 (#3345)
7e70852 
Bumps [i18next](https://github.com/i18next/i18next) from 23.16.5 to 23.16.6.
- [Release notes](https://github.com/i18next/i18next/releases)
- [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md)
- [Commits](i18next/i18next@v23.16.5...v23.16.6)

---
updated-dependencies:
- dependency-name: i18next
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
New changes for the AddPolicyForm
7b5da2e
Region Style changes
35e5a79
@pi1814 pi1814 requested a review from a team November 21, 2024 03:41
@pi1814 pi1814 marked this pull request as draft November 21, 2024 03:43
parth inamdar and others added 6 commits November 21, 2024 11:56
Fixing type errors in AddPolicyForm
2e32126 
Adding translations in AddPolicyForm
Adding changes for the tooltip issue
e5b3b7f
Added changes to 'Select All' functionality
f9d5342
@dependabot
Bump i18next from 23.16.6 to 23.16.8 (#3353)
c11358d 
Bumps [i18next](https://github.com/i18next/i18next) from 23.16.6 to 23.16.8.
- [Release notes](https://github.com/i18next/i18next/releases)
- [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md)
- [Commits](i18next/i18next@v23.16.6...v23.16.8)

---
updated-dependencies:
- dependency-name: i18next
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@deepakprabhakara
npm update
78313ab
@deepakprabhakara
Release 1.31.0
b1817e5
deepakprabhakara and others added 7 commits November 23, 2024 00:46
@deepakprabhakara
updated node, updated terminus api endpoints
29525d5
@deepakprabhakara
fix for redis getAll() on ttl stores (#3355)
10725ff 
* fix for redis getAll() on ttl stores

* lint fix

* revert ttl

* revert accidental commit

* skip mongo ttl test

* skip dynamodb ttl test

* cleanup

* cleanup expired createdAtPrefix
@deepakprabhakara
Release 1.32.0
8634bc1
Add backend integration for the LLM Policies UI
a513ede
@deepakprabhakara
Merge branch 'llm-policy' into llm-policies-ui-schema
b8f1d3c
@deepakprabhakara
updated deployment
1ac7fab
@deepakprabhakara
Merge branch 'main' into llm-policies-ui-schema
849e8f2 
# Conflicts:
#	npm/package-lock.json
#	package-lock.json
#	package.json
@deepakprabhakara deepakprabhakara changed the base branch from main to llm-policy November 26, 2024 01:54
deepakprabhakara and others added 3 commits November 26, 2024 02:00
@deepakprabhakara
Merge branch 'main' into llm-policy
e49d4d4 
# Conflicts:
#	npm/package-lock.json
#	package-lock.json
#	package.json
@deepakprabhakara
Merge branch 'llm-policy' into llm-policies-ui-schema
c389755 
# Conflicts:
#	package-lock.json
#	package.json
Added the following changes:
729a5c2 
Navigation to list after Policy creation

Changing edit policy button to save

Checkbox clicking issue resolved

Button sizes uniform as per UI

Columns Product and Policy restructuring

Added additional type for supported languages
@pi1814 pi1814 marked this pull request as ready for review November 26, 2024 04:55
Added changes:
39470fe 
1. Resolved Checkbox selection issue in entities
2. Added enum and const to handle supported languages and entoty descriptions respectively
3. Changed the request parameter language to ISO Codes
4. Reduced languges to ones supported (en, es, de)
@deepakprabhakara deepakprabhakara changed the base branch from llm-policy to chatui November 26, 2024 14:40
deepakprabhakara
deepakprabhakara reviewed Nov 29, 2024
View reviewed changes
package.json
@@ -83,7 +83,7 @@
"formik": "2.4.6",
"groq-sdk": "0.5.0",
"i18next": "23.16.8",
"lucide-react": "0.461.0",
"lucide-react": "^0.461.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always pin the version so it doesn't move around

deepakprabhakara
deepakprabhakara reviewed Nov 29, 2024
View reviewed changes
package.json
@@ -93,12 +93,13 @@
"nodemailer": "6.9.16",
"ollama": "0.5.2",
"openai": "4.52.7",
"prismjs": "1.29.0",
"prismjs": "^1.29.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always pin the version so it doesn't move around

deepakprabhakara
deepakprabhakara reviewed Nov 29, 2024
View reviewed changes
package.json
"raw-body": "3.0.0",
"react": "18.3.1",
"react-daisyui": "5.0.5",
"react-dom": "18.3.1",
"react-i18next": "15.1.1",
"react-simple-code-editor": "^0.14.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always pin the version so it doesn't move around

deepakprabhakara
deepakprabhakara reviewed Nov 29, 2024
View reviewed changes
internal-ui/package.json
@@ -22,6 +22,7 @@
"prepublishOnly": "npm run build"
},
"dependencies": {
"lucide-react": "^0.461.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't go here but in peerDependencies

@deepakprabhakara
Copy link
Member

@pi1814 should remove heroicons from package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakprabhakara deepakprabhakara deepakprabhakara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pi1814 @deepakprabhakara @niwsa