Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a plugin: kubectl tail #34

Closed
ahmetb opened this issue May 14, 2019 · 4 comments
Closed

Make a plugin: kubectl tail #34

ahmetb opened this issue May 14, 2019 · 4 comments

Comments

@ahmetb
Copy link

ahmetb commented May 14, 2019

👋 Hello, maintainer of the kubectl plugin manager krew here (https://github.com/kubernetes-sigs/krew).

What do you think of distributing this as a kubectl plugin named kubectl tail?

Why?

  • kubectl plugins are becoming a thing now, we have over 30 plugins.
  • kubectl tail is more natural and memorable than a custom binary name
  • krew helps you package/distribute your tool on macOS, Linux and Windows so you don't deal with homebrew, apt/dnf, chocolatey etc separately.

I suspect there would be no code changes required. The release process would involve periodic updates to the plugin manifest file hosted at https://github.com/kubernetes-sigs/krew-index/tree/master/plugins.

@boz
Copy link
Owner

boz commented May 15, 2019

Hi @ahmetb, thanks for reaching out.

Yes, that sounds great! Do plugins have to adhere to any standards such as argument parsing, etc...?

Is there anything I need to do other than to make a PR for the manifest file?

@ahmetb
Copy link
Author

ahmetb commented May 15, 2019

We only enforce naming guidelines in krew-index repo.
Ideally you should use the k8s.io/cli-runtime/pkg/genericclioptions for the flags like -n/-namespace, but it’s optional.

Give it a try sometime. We have a developer guide in krew repository.

@boz
Copy link
Owner

boz commented May 29, 2019

fixed in kubernetes-sigs/krew-index#150

@boz boz closed this as completed May 29, 2019
@ahmetb
Copy link
Author

ahmetb commented May 29, 2019

You can also document installation as a plugin if you’d like.

  1. Install krew
  2. kubectl krew install tail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants