Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] rewrite in typescript #2561

Closed
StarHosea opened this issue Mar 24, 2023 · 2 comments
Closed

[feature] rewrite in typescript #2561

StarHosea opened this issue Mar 24, 2023 · 2 comments

Comments

@StarHosea
Copy link

I love pdfmake so much, I am trying to add some feature for my , but i find some it's not easy to understand and modify the code without typescript , do we have any plan for typescirpt ?

@xDivisionByZerox
Copy link

I think some bugs could be found during the migration process as well. Unhandled edge cases on object properties for example.
While I'm a big TypeScript enthusiast as well I still have to ask.

What would be the benefit over simply extending the documentation (JSDocs)?
A lot of code already uses type declarations via JSDocs. This is enough for most IDEs/editors to complain about mismatching types and still gives the maintainer/contributer a clear enough image of what to expect.
So why go all the way to TypeScript, require an additional build step, get frustrated over the Transpiler (in strict mode) and throw a lot of resources at something that could be achieved with an easier way?

While I think this step would benefit the project in the long run, I simply want to point out that it's not that easy to migrate an existing project as big as pdfmake without decent knowledge in both JS and TS.

@liborm85
Copy link
Collaborator

Version 0.3 is rewrited to ES6+.
Rewriting to typescript is not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants