Skip to content

Latest commit

 

History

History
79 lines (53 loc) · 3.46 KB

README.md

File metadata and controls

79 lines (53 loc) · 3.46 KB
Raw

git-owners Build Status Coverage Status

git-owners is a system (inspired by the Chromium OWNERS system) to assign ownership to directories in a repository for the purposes of checking that a PR has been reviewed by sufficiently knowledgeable reviewers.

This project defines an OWNERS file format and includes tooling for finding reviewers for a set of files and given a set of files and acceptances verifying that all ownership rules are satisfied.

OWNERS file format

An example OWNERS file:

# flags can be set to change resolving behaviour
@set noparent

# alice can approve any change within this directory
alice

# bob can approve any change to a go file in this directory
bob *.go

# carol can approve changes to go files in this directory but not subdirectories
carol ./*.go

# BUILD files do not need a reviewer
@ignore BUILD

# dave and eve are not required to review changes but should be notified
@watcher dave
@watcher [email protected]

@watcher fred *.go

Full specification of available directives is given below.

CLI

Find owners for a file

git owners [-a] pathToFile

Prints out the owners of a file, one per line. If -a is given then all owners will be resolved up to the root of the repo else the resolver will stop after the first OWNERS file.

Find reviewers for a PR

git owners [--base-branch <name=master>]

Finds the commit on base-branch (default master) that this was branched from and gets the list of files changed since that commit. Outputs a list of reviewers that satisfies the property:

For every modified file there is at least one owner (or group of owners) in the list of reviewers that is an owner for that file.

This will attempt to find a minimal set of reviewers (i.e. minimise the amount of redundant reviews where two owners of a file review the same file) however this is only best effort. This process is non-deterministic so suggestions will be load balanced between owners.

Specification

Flags

A flag is of the form @set flagname and sets the given flag name to true. Any string is allowed for a flag name however this implementation only recognises the noparent flag.

Owners

An owner directive is of the form of a username/email followed by an optional filename pattern, separated by whitespace. If no filename pattern is given, it is equivalent to specifying a pattern of "*"

A filename pattern is any valid golang match pattern.

Ignores

An ignore directive is of the form @ignore followed by a filename pattern.

Watchers

A watchers directive is of the same form as an owners directive but prefixed with @watcher.

Resolution algorithm

Given a path to a file in a repo the set of owners is constructed as follow:

  1. If there is not and OWNERS file in the current directory move to the parent and GOTO 1.
  2. For each owner/group of owners in the OWNERS file, if they match the given file then add them to the set of owners.
  3. If the noparent flag is not set then move to the parent directory and GOTO 1.

The resulting set is all of the users/groups of users who can approve a change to this file.