Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple elements at the same line #130

Open
raboof opened this issue Aug 25, 2015 · 6 comments
Open

Multiple elements at the same line #130

raboof opened this issue Aug 25, 2015 · 6 comments

Comments

@raboof
Copy link
Contributor

raboof commented Aug 25, 2015

Right now each new element (arrow or note) is drawn at a new 'line'.

It might be neat to also allow multiple elements on one line - though it'll probably be up to the user to make sure they don't cause overlap.

This could be represented using indentation:

A->B: Broadcast trigger
B->A: Broadcast message
  B->C: Broadcast message
  Note right of C: Yay!
B->A: Delivery ack
  A                     B                     C
  |                     |                     |
  |  Broadcast trigger  |                     |
  | ------------------> |                     |
  |                     |                     |
  |  Broadcast message  |  Broadcast message  |
  | <------------------ | ------------------> | Yay!
  |                     |                     |
  |     Delivery ack    |                     |
  | <------------------ |                     |
  |                     |                     |
raboof added a commit to raboof/js-sequence-diagrams that referenced this issue Aug 25, 2015
When a note or signal is indented with '=' it is shown on the same height as
the latest note or signal without indentation.

This is just a PoC implementation of bramp#130. The formatting is mucked up and the
logic is a bit hard to read. If we decide this is a useful feature we probably
want to make 'lines' (collections of notes/signals that are on the same line)
a first-class citizen.
@raboof
Copy link
Contributor Author

raboof commented Aug 25, 2015

A->B: Trigger broadcast
B->A: Broadcast message
=B->C: Broadcast message
=Note right of C: Yay
B->A: Ack broadcast

selection_033

@zagor
Copy link

zagor commented Feb 5, 2016

Yes, I would love this too. I need to describe a system with broadcast messages, and have been unable to find ANY sequance diagram drawing tool that support it.

Just a minor comment about the prototype: There needs to be a marker on the vertical line of the sender, to show who sent the message.

@raboof
Copy link
Contributor Author

raboof commented Feb 5, 2016

You mean this diagram is ambiguous because it could also be interpreted to mean A and C sent 'broadcast' messages to each other? I suppose that makes sense - but might be something for a separate PR/issue. #129 would be an alternative way to remove this ambiguity.

@zagor
Copy link

zagor commented Feb 5, 2016

I mean if there was a fourth actor D, and B sent to A and D, there would be no visual indication that B sent the message rather than C.

@raboof
Copy link
Contributor Author

raboof commented Feb 5, 2016

Ah yes, that's a more realistic example of the same ambiguity indeed :).

@ensonic
Copy link

ensonic commented Jun 14, 2016

+1 I was looking for a way to have concurrent notes. At least those are not ambigous.

Maybe the start of a line can have a small dot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants