-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fipp won't compile with cljsbuild projects #42
Comments
Thanks for the report. As far as I know, there are numerous folks using Fipp from ClojureScript. Personally, I don't use cljsbuild, so I'd rather not debug it myself unless you can demonstrate the problem is with Fipp (or its dependencies) rather than cljsbuild. Presumably that exception has a "cause" below the first stack trace. What does it say? |
i actually think the problem is with the rrb-vector library (see full i've removed the dependency on rrb_vector (for cljs compilations) in i wouldn't claim that's a demonstration, though. for instance, the
|
Hmm... a very cursory look suggests that there's both a 1-arity ranges function and 2-arity ranges macro. Maybe this is a ClojureScript bug in the newer versions that support automatically importing macros from the same namespace? |
I don't quite remember the issue, but it's related to what you're talking about, @brandonbloom . I had to fork |
thanks alex, i'll give it a try as soon as i can! |
No problem! Let me know how it goes. |
I ran into this issue as well. I was able to make my build work by excluding
|
rrb-vector issue is at https://dev.clojure.org/jira/browse/CRRBV-15, currently lacks a reproducible case. |
@alexandergunnarson Is the code available for your quantum/... build anywhere? If it's a small patch, you can just paste it here too. |
@brandonbloom My fork is here. Only the changes made to the .cljs files are relevant — it was a simple naming conflict that caused issues in CLJS. You can see the diff here. There is possibly a cleaner fix that involves fewer changes to code, but this is what I have so far, and it works. |
OK, I'm reasonably convinced that this should be fixed in cljs-build, not in rrb-vector or fipp. Maaaybe something in cljs itself. |
I tentatively agree. Definitely not an issue with fipp either way. |
OK, tracking over there: emezeske/lein-cljsbuild#469 |
Sounds good @brandonbloom! |
The just-released version 0.0.14 of core.rrb-vector fixes the issue https://dev.clojure.org/jira/browse/CRRBV-15 that was originally reported in Fipp as brandonbloom#42.
The issue is easy to replicate. Just create a new project.clj
and put a dummy
cljc
file insrc/test_fipp/core.cljc
:now try to compile it with:
and you'll get an exception that starts like this:
i think the problem might be in the rrb library, but seeing most of
the bugs reports in its jira have been unattended for more than a
year, i've opted for avoiding rrb in the deque namespace for the time
being :).
The text was updated successfully, but these errors were encountered: