Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate turbo #72

Open
vovayatsyuk opened this issue Nov 4, 2024 · 1 comment
Open

Deprecate turbo #72

vovayatsyuk opened this issue Nov 4, 2024 · 1 comment

Comments

@vovayatsyuk
Copy link
Member

vovayatsyuk commented Nov 4, 2024

Turbo - is a library that transforms the site into SPA.

It also requires js code that will cleanup the modified DOM structure, and remove event listeners. Otherwise, we will get memory leaks, js errors about multiple initialization, etc. Unfortunately, the majority of Magento modules are written for traditional page reloads, when the browser will destroy everything on each navigation.

Take a look at some of our fixes to third-party modules just for Turbo compatibility:

Also, we disable Turbo in some integrations:

Because of that, I think we should disable turbolinks in the next updates, and, eventually, remove the library from the code.

@vovayatsyuk
Copy link
Member Author

vovayatsyuk commented Nov 5, 2024

Fixed check of the turbo status: 91e5494
Changed default status in blank theme: breezefront/theme-frontend-breeze-blank@a85d97d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant