Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e of examples #697

Open
aralroca opened this issue Jan 1, 2025 · 5 comments
Open

add e2e of examples #697

aralroca opened this issue Jan 1, 2025 · 5 comments
Assignees

Comments

@aralroca
Copy link
Collaborator

aralroca commented Jan 1, 2025

I tried it and it is as draft in a PR, but there are things to improve, such as Bun processes that remain open, and improve the GitHub Action...

I create the issue in case someone else wants to lend a hand with this and use the PR draft as a reference (if you want).

Currently, the examples folder does not have e2e tests, and it would be nice to have them to ensure that they do not break during releases.

@aralroca aralroca self-assigned this Jan 1, 2025
@space-techy
Copy link

Hello,
I wanted to know more about this?
Can you brief it?
As I would like to work on it!

@aralroca
Copy link
Collaborator Author

aralroca commented Jan 10, 2025

@space-techy thanks! I experimented in this draft PR #600 but I have had several problems, the tests pass most of them fine, but there is a bug with open Bun processes.

It's been a while since I've worked on this topic. So, it will be very welcome any contribution to it. It would be great if you could lend a hand. Feel free to use the draft PR for reference or start over.

The idea would be to cover e2e of the examples with Playwright. The challenge here is that it's not a single project, it's several (each example is a different Brisa project). Maybe my mistake was to create a test file for everything, instead of each example having its own file.

@space-techy
Copy link

space-techy commented Jan 10, 2025

Hello @aralroca,

Thank you for giving me this opportunity!

I’m completely new to Brisa Repo and don’t have much knowledge about it yet. If possible, could you provide more information, along with any code pointers or documentation? I would truly appreciate it.

I understand this might feel like a bit of an extra ask, but I assure you that I’ll give my best to contribute effectively. Additionally, I’d love to learn more details about the issue at hand.
Also I am currently going through all files!

Thank you so much!

@aralroca
Copy link
Collaborator Author

@space-techy take a look at https://github.com/brisa-build/brisa/blob/canary/CONTRIBUTING.md to the deployment environment

Then, all the examples are in: https://github.com/brisa-build/brisa/tree/canary/examples

These examples are the same that appear here: https://brisa.build/examples

In the README of each example there is documentation about how to try them locally 😊

@space-techy
Copy link

Thank You @aralroca
I will start working on it now!
Firstly I will look into all the links you have given
And then look into main issue 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants