found bug while testing bu_process

f4alt · f4alt · commit 2476144d22ba · 2024-04-23T03:17:54.000-04:00
diff --git a/BUGS b/BUGS
@@ -15,6 +15,10 @@ on-going issues.
 Recent Bugs
 -----------
 
+* rtcheck_handler_cleanup() throws 'invalid handle specified' on Windows
+  in closing of STDOUT (see FIXME comment). Does not affect normal running,
+  but a debug build complains.
+
 * very peculiar non-linear memory issue in rt when allocating a large
   flat hierarchy of objects.  I have three combs, each with 10k
   members unioned. Each member is an rcc.  Rendering with just one
diff --git a/src/libged/rtcheck/rtcheck.c b/src/libged/rtcheck/rtcheck.c
@@ -60,6 +60,7 @@ rtcheck_handler_cleanup(struct ged_rtcheck *rtcp)
 	(*gedp->ged_delete_io_handler)(rrtp, BU_PROCESS_STDERR);
     }
 
+    // FIXME: Windows throws 'invalid handle specified' exception here - is ged_delete_io_handler already closing STDOUT?
     bu_process_close(rrtp->p, BU_PROCESS_STDOUT);
 
     /* wait for the forked process */

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,7 @@ rtcheck_handler_cleanup(struct ged_rtcheck *rtcp)`
`60`	`60`	`(*gedp->ged_delete_io_handler)(rrtp, BU_PROCESS_STDERR);`
`61`	`61`	`}`
`62`	`62`
	`63`	`+ // FIXME: Windows throws 'invalid handle specified' exception here - is ged_delete_io_handler already closing STDOUT?`
`63`	`64`	`bu_process_close(rrtp->p, BU_PROCESS_STDOUT);`
`64`	`65`
`65`	`66`	`/* wait for the forked process */`