-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[portable-rustls] add CI build testing for multiple targets with no atomic ptr (src update deferred) - CI FAILURE EXPECTED #3
Conversation
a963e4d
to
ba584d8
Compare
.github/workflows/build.yml
Outdated
# XXX TBD add feature to configure critical-section - ??? | ||
- run: cargo add once_cell -F critical-section -p portable-rustls | ||
- run: cargo add portable-atomic -F critical-section -p portable-rustls | ||
- run: cargo add spin -F portable_atomic -p portable-rustls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a little while to figure out that using "portable-atomic" feature with a dash (-
) didn't work due to mvdnes/spin-rs#170 - proposed mvdnes/spin-rs#172 to fix this.
.github/workflows/build.yml
Outdated
# XXX XXX WORKAROUND NEEDED for getrandom 0.2.x | ||
- run: cargo add [email protected] -F custom -p portable-rustls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty unhappy with the number of crates still directly or indirectly using outdated [email protected], hope to see this situation improve in the near future.
a3c31c2
to
d55e0f4
Compare
…ew portable-rustls-ci-build.yml - XXX XXX CI FAILURE EXPECTED WITH THESE UPDATES
46e9a52
to
bb17b67
Compare
STATUS:
Arc
for target with no atomic ptr - need to check recent updatesDEFERRED ITEMS - deferred to another PR:
portable_atomic_util::Arc
to resolve this issueOPEN QUESTION(S):