Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portable-rustls] add CI build testing for multiple targets with no atomic ptr (src update deferred) - CI FAILURE EXPECTED #3

Closed
wants to merge 1 commit into from

Conversation

brody4hire
Copy link
Owner

@brody4hire brody4hire commented Feb 4, 2025

STATUS:

  • EXPECTED to FAIL at this point - should fail due to missing Arc for target with no atomic ptr - need to check recent updates

DEFERRED ITEMS - deferred to another PR:

  • TODO: use portable_atomic_util::Arc to resolve this issue
  • TODO: update documentation

OPEN QUESTION(S):

  • feature-based configuration to select "std" Arc (alloc::sync::Arc) vs portable-atomic (portable-atomic-util) Arc - may be able to defer this
  • add some kind of "critical-section" feature to enable "critical-section" in once_cell & possible transitive portable-atomic dep(s) - may be able to defer this
  • always use once_cell sync feature instead of once_cell::race if "critical-section" feature is enabled - this looks like a pretty small but nice optimization

@brody4hire brody4hire force-pushed the brody-no-atomic-ptr-support branch from a963e4d to ba584d8 Compare February 4, 2025 06:05
# XXX TBD add feature to configure critical-section - ???
- run: cargo add once_cell -F critical-section -p portable-rustls
- run: cargo add portable-atomic -F critical-section -p portable-rustls
- run: cargo add spin -F portable_atomic -p portable-rustls
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a little while to figure out that using "portable-atomic" feature with a dash (-) didn't work due to mvdnes/spin-rs#170 - proposed mvdnes/spin-rs#172 to fix this.

Comment on lines 446 to 447
# XXX XXX WORKAROUND NEEDED for getrandom 0.2.x
- run: cargo add [email protected] -F custom -p portable-rustls
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty unhappy with the number of crates still directly or indirectly using outdated [email protected], hope to see this situation improve in the near future.

@brody4hire brody4hire changed the title [portable-rustls] no atomic ptr support - START with CI build testing - EXPECTED to FAIL for now [portable-rustls] add CI build testing for targets with no atomic ptr - for CI testing only (update deffered) - CI FAILURE EXPECTED Feb 4, 2025
@brody4hire brody4hire changed the title [portable-rustls] add CI build testing for targets with no atomic ptr - for CI testing only (update deffered) - CI FAILURE EXPECTED [portable-rustls] add CI build testing for multiple targets with no atomic ptr - for CI testing only (update deffered) - CI FAILURE EXPECTED Feb 4, 2025
@brody4hire brody4hire changed the title [portable-rustls] add CI build testing for multiple targets with no atomic ptr - for CI testing only (update deffered) - CI FAILURE EXPECTED [portable-rustls] add CI build testing for multiple targets with no atomic ptr (src update deferred) - CI FAILURE EXPECTED Feb 4, 2025
@brody4hire brody4hire force-pushed the brody-no-atomic-ptr-support branch from a3c31c2 to d55e0f4 Compare February 7, 2025 02:15
…ew portable-rustls-ci-build.yml - XXX XXX CI FAILURE EXPECTED WITH THESE UPDATES
@brody4hire brody4hire force-pushed the brody-no-atomic-ptr-support branch from 46e9a52 to bb17b67 Compare February 9, 2025 06:32
@brody4hire brody4hire closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant