Skip to content

Commit a915186

Browse files
committed
Jasmine: Formats jasmine plugin and fixes the interval clearing
It makes no sense to clear the interval while Jasmine is still running, potentially never reporting results when the suite didn't finish after the first interval ran. Closes #88
1 parent 76c65ff commit a915186

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

lib/_patch/jasmine-plugin.js

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,45 @@
11
(function(){
22
function countSpecs(suite, results){
3-
for(var i = 0; i < suite.specs.length; ++i) {
4-
if(suite.specs[i].passed){
5-
results.passed++;
3+
for (var i = 0; i < suite.specs.length; ++i) {
4+
if (suite.specs[i].passed){
5+
results.passed++;
66
} else {
77
results.tracebacks.push(suite.specs[i].description);
88
results.failed++;
99
}
1010
}
1111

12-
for(var i = 0; i < suite.suites.length; ++i) {
13-
if(suite.suites[i]) {
12+
for (var i = 0; i < suite.suites.length; ++i) {
13+
if (suite.suites[i]) {
1414
results = countSpecs(suite.suites[i], results);
1515
}
1616
}
17-
18-
return(results);
17+
18+
return results;
1919
}
2020

21-
var checker = setInterval(function(){
22-
if(!jasmine.running){
21+
var checker = setInterval(function() {
22+
if (!jasmine.running) {
2323
var results = {};
2424
var report = jasmine.getJSReport();
2525
results.runtime = report.durationSec * 1000;
26-
results.total=0;
27-
results.passed=0;
28-
results.failed=0;
29-
results.tracebacks=[];
26+
results.total = 0;
27+
results.passed = 0;
28+
results.failed = 0;
29+
results.tracebacks = [];
3030

31-
for(var i = 0; i < report.suites.length; ++i) {
32-
if(report.suites[i]) {
33-
results = countSpecs(report.suites[i], results);
34-
}
31+
for (var i = 0; i < report.suites.length; ++i) {
32+
if (report.suites[i]) {
33+
results = countSpecs(report.suites[i], results);
34+
}
3535
}
36-
36+
3737
results.total = results.passed + results.failed;
3838

3939
results.url = window.location.pathname;
4040
BrowserStack.post("/_report", results, function(){});
41+
clearInterval(checker);
4142
}
42-
clearInterval(checker);
4343
}, 1000);
4444
})();
4545

0 commit comments

Comments
 (0)