Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: "reset" for tempo-based, oscillating effects #25

Open
cyrusadkisson opened this issue Nov 18, 2020 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@cyrusadkisson
Copy link

(Not a bug, but a feature request.)

I use guitarix almost exclusively inside Ardour, relying heavily on automation points to toggle and adjust the effects as the song plays. I'm having an issue when I need an effect that has its own internal tempo (chorus, flange, tremolo and vibe) matched to the tempo of the song.

But I'm NOT asking for tempo matching (although that would be nice). My issue is something else. Read on.

What's happening is there will be a part of the song where, say, tremolo is enabled, but the trem is not at the correct point in its sine/triangle curve. Even if I get the trem effect perfectly matched to the tempo of the song, the "enable" signal may catch the trem in the trough of its sine wave.

Even if the trem tempo were 100% perfectly matched to the tempo of the song, the user can start playback at any time. So it's impossible to know at which part of the sine wave the tremolo effect will be when it comes time for it to be enabled.

What I need is a "reset" switch on these types of effects so that I can "reset" the sine wave (or triangle or whatever) at the same time the effect is toggled on.

I hope I explained this well enough. Image attached. https://imgur.com/3MVIqrb Let me know if I need to try again.

@brummer10 brummer10 added the enhancement New feature or request label Nov 18, 2020
@brummer10
Copy link
Owner

So, you need a switch which reset the osc wave to the start point, as if it just starts when ever you reset. Is that right?
I could add that true. Just let me know if I understand you correct on this.

regards
hermann

@cyrusadkisson
Copy link
Author

Yes, that's correct. Applies to anything with a sine wave or oscillation like chorus, flange, leslie, trem, vibe, etc.

Delay has a tempo, but it's fine since it always starts from the generation of the sound.

Thanks!

@brummer10
Copy link
Owner

Okay, here is the one for GxTremolo.lv2
Please checkout and test it, if it is what you need I could add it to the others you need (please attach a list)

regards
hermann

@magnetophon
Copy link

magnetophon commented Jun 22, 2021

I also think this is a very useful feature!

Unfortunately, when I hit the reset button in GxTremolo.lv2, the plugin breaks: there is silence with maximum depth, and something that sounds like ring-modulation at zero depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants