-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognise and use parking:both and cycleway:both #788
Comments
Two additions: I think what you write should be true for all presets of the type This is the implementation of this field in iD. This preset type used to be called Another things for the |
Oh, yeah, definitely! So far, I only found those two to be an issue for my tagging usage but I’m open to extend this issue into a general “support
Hah, didn’t know that. Thanks for the info and the link! I’ll read up on what you proposed. |
Thanks for the comment @tordans, my first question was whether this was something that could be made more general rather than coding for a specific tag. |
Yes, it's a good first step. There are quite a few things that are missing, yet in the tagging schema to really model the more complex tagging schema like the I hope to start a effort to get more of this more detailed left/right data into the presets. There are some thought on this in openstreetmap/id-tagging-schema#1202 . |
Issue description
When setting Parking or Bike lanes on a way, they are set as
parking:left
+parking:right
, andcycleway:left
+cycleway:right
even if both sides have the same value.Similarly, even if a way already has
parking:both
and/orcycleway:both
set, Go Map!! doesn’t recognise that and shows both tags as unset, allowing you to set them. If you do, they are again set as*:left
and*:right
.Use case
When using Go Map!!, I most often use the “Common tags” view for the usually interesting tags for that specific node or way. For ways, Parking and Bike lanes are available in the common tags view for easy setting.
I often set values there for the left and right side of a way only to later find out through Osmose’s issue list that there are now duplicate tags because Go Map!! didn’t parse the
*:both
tags in a way that they are shown for both the*:left
and*:right
variant.Proposal
Same as iD, Go Map!! should
parking:both
asparking:left
andparking:right
to show already existing values in the handy Common tags view for Parking (and Parking orientation). Same forcycleway:both
.parking
orcycleway
to the same value, they should be saved asparking:both
andcycleway:both
, notparking:left
+parking:right
/cycleway:left
+cycleway:right
with the same value for eachPotential issues
Duplication already exists
A way could already have e.g.
In that case, the
both
value should probably be used. Maybe already remove the separate values if changing parking for the way?Conflicting values already exist
A way could already have e.g.
Here, parsing could not reliably be done and both variants could be correct or wrong. An error / warning would probably make sense.
The text was updated successfully, but these errors were encountered: