New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiplication overflow #48

Closed

bschwind opened this issue Jun 10, 2022 · 0 comments · Fixed by #49

Assignees

Owner

bschwind commented Jun 10, 2022

Caught by the fuzz tests:

mqtt-broker/mqtt-v5/src/decoder.rs

Lines 103 to 105 in 9037df2

    
           // TODO(bschwind) - Fuzzer panicked at 'attempt to multiply with overflow' 
        
           //                  Test with this input: [81, 251, 230, 255, 255, 255] 
        
           value += ((encoded_byte & 0b0111_1111) as u32) * multiplier;

bschwind self-assigned this

bschwind mentioned this issue

Fixed Overflow in decoding #49

Merged

bschwind closed this as completed in #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment