Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add "Product details" page #206

Closed
AkashPaloju opened this issue Jul 9, 2024 · 8 comments · Fixed by #211
Closed

[Feature Request]: Add "Product details" page #206

AkashPaloju opened this issue Jul 9, 2024 · 8 comments · Fixed by #211
Assignees

Comments

@AkashPaloju
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently we don't have the product details page

Describe the solution you'd like

https://www.figma.com/design/5Hs4DlvyJJWjQB9K7Fh0CY/Getit?node-id=930-740&t=1jjSHLWA3KQ7UPHf-0

Add the product details page according to the figma

Describe alternatives you've considered

No response

Developer Help

Refer how the event details page is implemented in Getit

General notes for Developers:

Once you have a good understanding of the issue, you can ask for it to be assigned to you by leaving a comment as follows: Explain clearly how you'd tackle the issue at a minimum, point to which file(s) (mention their links in the repo) you'd modify, and describe the changes you'd make. If creating new files is necessary, specify where you would place them and outline the content you would add to resolve the issue.

If your explanation sounds good, we'll assign the issue to you.

@yashpatil641
Copy link
Contributor

yashpatil641 commented Jul 9, 2024

@AkashPaloju I would like to work on the issue i will create a new id.vue file inside the products folder and use tailwind css for styling

  1. Size Chart Section and Product Details Section Visible State:

I will use Vue.js reactive data properties to control the visibility of these sections.
I will create methods to toggle the visibility state when the respective buttons are clicked.
The visibility will be managed using v-if v-show directives in the template.

  1. Share Button:

I will implement a share button that copies the current page URL to the clipboard.
Will use window.location.href to get link for the page.
The button will use the navigator.clipboard.writeText API to copy the URL. And show a pop-up notifying the user that url has been copied.

I will fetch data from backend for images and details.
Will add carousel for more images of product.
For more products section i will import merchcard component.

@AkashPaloju
Copy link
Collaborator Author

AkashPaloju commented Jul 9, 2024

This time , as this is a hard issue, please incude how you'd implement/handle the "Size chart section" , "Product Details section" visible state, how you'd put the correct link in the share(/icon) button (you need to put the current page url in the button and it should be copied to the user's clipboard when clicked)

@blazethunderstorm
Copy link
Contributor

@AkashPaloju i would like to work on this issue i would use vue icons to add desirable icons in buttons and would tailwind.css for further css, for size i woul pass a list and allow user to chose from it using radio andn for product detail i will create an accordian

@blazethunderstorm
Copy link
Contributor

blazethunderstorm commented Jul 9, 2024

  1. For share i would pass on click on it , for size chart i can create a drop down (v-show) using list

  2. For product detail section as a mentioned i would create an accordian (by its bool value)

  3. For copying i would use javascript's window location to get its url , then this button will use the navigator.clipboard.writeText API to copy the URL. And show a pop-up notifying the user that url has been copied

  4. Add to cart/buy now should redirect to their page respectively

  5. For image for carousel and others i would fetch data from backend

@ShashaankS
Copy link
Contributor

ShashaankS commented Jul 9, 2024

@AkashPaloju I would like to work on this issue, I will be implementing dynamic visibility toggles for the "Size Chart" and "Product Details" sections using Vue.js. Utilize Vue's v-show directive or a drop-down to toggle visibility based on user's click.
For share button that will copy to clipboard the current url of the webpage to generate correct product URLs dynamically.
Fetch product data from Django backend via API calls and related products as well.

@Kushdapush
Copy link
Collaborator

ok, we will go forward with @ShashaankS this time.

@AkashPaloju
Copy link
Collaborator Author

AkashPaloju commented Jul 9, 2024

Just a note, if a PR is not created within a reasonable time(depends on difficulty level), we will unassign the assignee. Thanks!

@Kushdapush
Copy link
Collaborator

Also feel free to ask any doubts or for help

ShashaankS pushed a commit to ShashaankS/GetIt that referenced this issue Jul 16, 2024
@AkashPaloju AkashPaloju linked a pull request Jul 22, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants