Make imagePullPolicy configurable

[calvinbui]

It is currently set to Always which slows down our builds when the image is already present on the host.

For example, it already pulled the image for copy-agent init container, but then has to pull it again for the checkout and agent containers.

This also includes the job/step container.

agent-stack-k8s/internal/controller/scheduler/scheduler.go

Line 243 in 3bf9caa

c.ImagePullPolicy = corev1.PullAlways

agent-stack-k8s/internal/controller/scheduler/scheduler.go

Line 315 in 3bf9caa

ImagePullPolicy: corev1.PullAlways,

[triarius]

Thanks for raising this @calvinbui. We think it's a good idea to be able to do this. We've added this to our roadmap, but we're unable to commit to a timeline at this stage. In the meantime, a PR that plumbs this from the helm chart into the controller's config into these lines of code would be welcome.

[42atomys]

Hi, the pull request #262 will make ti configurable easier 💯

[calvinbui]

works so much better and faster now, that I think IfNotPresent should be the default.

my change:

"pod-spec-patch":
  "containers":
  - "imagePullPolicy": "IfNotPresent"
    "name": "agent"
  - "imagePullPolicy": "IfNotPresent"
    "name": "checkout"
  - "imagePullPolicy": "IfNotPresent"
    "name": "container-0"
  "initContainers":
  - "imagePullPolicy": "IfNotPresent"
    "name": "copy-agent"