Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api scopes for all build commands #420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

api scopes for all build commands #420

wants to merge 2 commits into from

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Dec 15, 2024

Changes

  • Introduce a pre-run check for API scope permissions
  • Error where permissions not included with token

lizrabuya
lizrabuya reviewed Dec 15, 2024
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcncl , everything looks good! But is it possible to move the command scope validation into the validation package since it will be reused across different commands?

lizrabuya
lizrabuya requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pkg/cmd/build/cancel.go
@@ -28,6 +29,23 @@ func NewCmdBuildCancel(f *factory.Factory) *cobra.Command {
Long: heredoc.Doc(`
Cancel the given build.
`),
PreRunE: func(cmd *cobra.Command, args []string) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request to optimise preRun function that appears on several portions in code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! How would you optimise this code? I'm not overly certain on a way to reduce it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrabuya lizrabuya lizrabuya requested changes

@PriyaSudip PriyaSudip Awaiting requested review from PriyaSudip PriyaSudip is a code owner

@jykingston jykingston Awaiting requested review from jykingston jykingston is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcncl @lizrabuya