Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how block step implicit dependencies work #1415

Open
pfiaux opened this issue Mar 17, 2022 · 0 comments
Open

Clarify how block step implicit dependencies work #1415

pfiaux opened this issue Mar 17, 2022 · 0 comments

Comments

@pfiaux
Copy link

pfiaux commented Mar 17, 2022

Concerning https://buildkite.com/docs/pipelines/block-step, the description of the block step feels ambiguous and could be clarified, especially this part:

however a block step creates implicit dependencies to the steps before and after it.

Context: Trying to make a block step only available after the steps that comb before.

Which dependencies (depends_on) are created implicitly isn't clear for instance if we have:

steps:
    - key: a
    - block
    - key: b

There seems to be resulting 2 possibilities/interpretations:

  1. block depends_on a, b depends_on block
  2. b depends_on [a, block]

The difference is that in 1. we can't unblock until a finished, in 2. we can unblock before a finishes. I believe the current behavior is 2. because block steps can be unblocked before previous steps finish.

To get behavior 1. I think this does it:

steps:
    - key: a
    - block
       depends_on: a
    - key: b

Can you confirm is this is correct? Also if that's the case it can you update the doc to make this more obvious maybe include something like the second example here? It would remove some guess work getting block steps to work in different use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant