Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pre-exit hooks #55

Open
elruwen opened this issue Jan 21, 2022 · 1 comment
Open

Support pre-exit hooks #55

elruwen opened this issue Jan 21, 2022 · 1 comment

Comments

@elruwen
Copy link

elruwen commented Jan 21, 2022

Moin!

Currently I can put a environment hook into S3. I would like to have support for the pre-exit hook.

I had a look at the code.

How about introducing another optional environment variable. It can be set to environment or pre-exit and if it is set to pre-exit, it does the same for pre-exit as it normally does for environment.

Would you accept such a contribution?

Cheers
Ruwen

@triarius
Copy link
Contributor

Hi @elruwen. Thanks for your question! We only want to support the use case of retrieving secrets from S3 in with this repo. If you would like to store part of an agent hook in S3, then it may be simpler to create the hooks in your agents hook path as bash scripts that download what then need from S3.

Perhaps if you could explan more about your use case and why you would like to run a pre-exit hook stored in S3 rather than, for example, a plugin stored in a git repo, we may be able to consdier this more throughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants